Merged
Conversation
* Still error, but almost hack for multipart data request * Replaced whitespace with line breaks as necessary * Somehow still failing. A bit out of ideas * Changed the encoding to ASCII * Using CRLF instead * Test pass. Renamed variables to be more selfexplanatory
mssfang
reviewed
Sep 14, 2023
sdk/openai/azure-ai-openai/src/test/java/com/azure/ai/openai/OpenAISyncClientTest.java
Outdated
Show resolved
Hide resolved
mssfang
reviewed
Sep 14, 2023
sdk/openai/azure-ai-openai/src/main/java/com/azure/ai/openai/implementation/MultipartField.java
Show resolved
Hide resolved
mssfang
reviewed
Sep 18, 2023
sdk/openai/azure-ai-openai/src/main/java/com/azure/ai/openai/OpenAIAsyncClient.java
Show resolved
Hide resolved
sdk/openai/azure-ai-openai/src/main/java/com/azure/ai/openai/OpenAIAsyncClient.java
Show resolved
Hide resolved
sdk/openai/azure-ai-openai/src/main/java/com/azure/ai/openai/OpenAIAsyncClient.java
Outdated
Show resolved
Hide resolved
sdk/openai/azure-ai-openai/src/main/java/com/azure/ai/openai/OpenAIAsyncClient.java
Show resolved
Hide resolved
jpalvarezl
changed the title
mssfang
reviewed
Sep 19, 2023
sdk/openai/azure-ai-openai/src/main/java/com/azure/ai/openai/OpenAIAsyncClient.java
Show resolved
Hide resolved
mssfang
reviewed
Sep 19, 2023
sdk/openai/azure-ai-openai/src/main/java/com/azure/ai/openai/OpenAIAsyncClient.java
Show resolved
Hide resolved
mssfang
suggested changes
Sep 19, 2023
sdk/openai/azure-ai-openai/src/main/java/com/azure/ai/openai/OpenAIAsyncClient.java
Show resolved
Hide resolved
sdk/openai/azure-ai-openai/src/main/java/com/azure/ai/openai/OpenAIAsyncClient.java
Show resolved
Hide resolved
sdk/openai/azure-ai-openai/src/main/java/com/azure/ai/openai/OpenAIClient.java
Show resolved
Hide resolved
sdk/openai/azure-ai-openai/src/main/java/com/azure/ai/openai/OpenAIClient.java
Show resolved
Hide resolved
sdk/openai/azure-ai-openai/src/main/java/com/azure/ai/openai/OpenAIClient.java
Show resolved
Hide resolved
sdk/openai/azure-ai-openai/src/main/java/com/azure/ai/openai/OpenAIClient.java
Show resolved
Hide resolved
mssfang
approved these changes
Sep 19, 2023
| additionalDirectories: | ||
| - specification/cognitiveservices/OpenAI.Authoring | ||
| commit: b646a42aa3b7a0ce488d05f1724827ea41d12cf1 | ||
| commit: dd2d1e8957ac6654272137e8d5874eacafd80a5f |
Member
There was a problem hiding this comment.
@jpalvarezl Please update the commit id to that of main branch, after audio.tsp get merged to main
Member
Author
There was a problem hiding this comment.
Will do as soon as the PR is merged. Unfortunately, the changes haven't made it to the main branch yet.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the first release, we are basing code generation in the looser types definition: Azure/azure-rest-api-specs#25734
Remaining TODOs:
plain/textformats and invalid requested formatsadd a convenience method handling the file opening?